[PATCH] D91441: [VP] Build VP SDNodes
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 13 15:58:46 PST 2020
craig.topper added inline comments.
================
Comment at: llvm/include/llvm/IR/VPIntrinsics.def:85
+// \p OC The standard IR opcode.
#ifndef HANDLE_VP_TO_OC
+#define HANDLE_VP_TO_OC(OC)
----------------
Can OC here be OPC? That's probably a more common abbreviation for opcode.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6140
return;
+#define BEGIN_REGISTER_VP_INTRINSIC(VPINTRIN, ...) case Intrinsic::VPINTRIN:
+#include "llvm/IR/VPIntrinsics.def"
----------------
Instead of adding all of the enumerated values to the switch, I wonder if it might sense to use a dyn_cast<VPIntrinsic> in the default case? Same for constrained fp.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91441/new/
https://reviews.llvm.org/D91441
More information about the llvm-commits
mailing list