[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/Util/annotation2metadata.ll:8
+ at .str.2 = private unnamed_addr constant [10 x i8] c"_remarks2\00", section "llvm.metadata"
+ at llvm.global.annotations = appending global [4 x { i8*, i8*, i8*, i32 }] [
+    { i8*, i8*, i8*, i32 } { i8* bitcast (void (float*)* @test1 to i8*), i8* getelementptr inbounds ([10 x i8], [10 x i8]* @.str, i32 0, i32 0), i8* getelementptr inbounds ([6 x i8], [6 x i8]* @.str.1, i32 0, i32 0), i32 2 },
----------------
Will It be the frontend's job to mark the array as `appending`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91195/new/

https://reviews.llvm.org/D91195