[PATCH] D91460: [AsmParser] make .ascii/.asciz/.string support multiple strings

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 15:23:58 PST 2020


jrtc27 added a comment.

In D91460#2395236 <https://reviews.llvm.org/D91460#2395236>, @jcai19 wrote:

> It appears that I misunderstood the existing code. It actually supports multiple string arguments, but only when commas are used between the arguments. GAS supports commas or spaces as the separator (or when both are used in the same call such as .ascii "aa", "bb" "cc ).  Will refactor my patch and update the commit message.

In which case I assume `.asciz "foo" "bar"` is equivalent to `.asciz "foobar"` rather than `.asciz "foo\0bar"` (same for `.string`), just like C string concatenation, and hence why both syntaxes exist?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91460/new/

https://reviews.llvm.org/D91460



More information about the llvm-commits mailing list