[PATCH] D84050: [YAMLIO] Support non-null-terminated inputs

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 14:17:03 PST 2020


scott.linder marked 3 inline comments as done.
scott.linder added inline comments.


================
Comment at: llvm/lib/Support/YAMLParser.cpp:1410-1411
 bool Scanner::scanAliasOrAnchor(bool IsAlias) {
-  StringRef::iterator Start = Current;
   unsigned ColStart = Column;
+  StringRef::iterator Start = Current;
   skip(1);
----------------
dexonsmith wrote:
> I don't have an opinion on the best order of these two lines, but if you want to flip them please do so in a separate NFC commit (and revert the change from this patch to make it as clean as possible).
My mistake, I didn't look over the diff closely enough before posting. Fixed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84050/new/

https://reviews.llvm.org/D84050



More information about the llvm-commits mailing list