[PATCH] D91461: [build] normalize components dependencies
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 13 14:04:45 PST 2020
Meinersbur added a comment.
This looks like an overdue fix. Thanks.
Before I accept it, have you tested multiple configurations (LLVM_LINK_DYLIB, CMAKE_SHARED_LIBS,...) to not break?
================
Comment at: llvm/lib/FileCheck/CMakeLists.txt:7
-target_link_libraries(LLVMFileCheck LLVMSupport)
+ LLVM_COMPONENT
+ Support
----------------
Isn't it LLVM_COMPONENT**S**?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91461/new/
https://reviews.llvm.org/D91461
More information about the llvm-commits
mailing list