[PATCH] D89734: [ms] [llvm-ml] Support macro function invocations in expressions

[Eric Astor via Phabricator via llvm-commits]

epastor added a comment.

In D89734#2394172 <https://reviews.llvm.org/D89734#2394172>, @thakis wrote:

> Can we also add a test where `EndStatementAtEOFStack` isn't empty at end-of-file?

As near as I can tell, that can't happen as written! I've added an assert for this.



================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3109
+
+  // Exit values may require lexing, unfortunately. We construct a new buffer to
+  // hold the exit value.
----------------
thakis wrote:
> I think the "require lexing" part is already covered by the test you're adding. Is that right?
Yes, that's correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89734/new/

https://reviews.llvm.org/D89734