[PATCH] D91435: [AMDGPU] Split edge to make si_if dominate end_cf

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Typos "do,imates" and "another predecessors" in message



================
Comment at: llvm/lib/Target/AMDGPU/SIAnnotateControlFlow.cpp:319-322
+    if (!DT->dominates(DefBB, BB)) {
+      // Split edge to make Def dominate Use
+      FirstInsertionPt = &*SplitEdge(DefBB, BB, DT, LI)->getFirstInsertionPt();
+    }
----------------
Is this the same as unconditionally calling SplitCriticalEdge?


================
Comment at: llvm/test/CodeGen/AMDGPU/virtual-register-defs-dont-dominate-all-uses.ll:3-5
+source_filename = "virtual-register-defs-dont-dominate-all-uses.ll"
+target datalayout = "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-S32-A5-ni:7"
+target triple = "amdgcn-amd-amdhsa"
----------------
Don't need these


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91435/new/

https://reviews.llvm.org/D91435