[PATCH] D91418: [LLD][ELF] Rename lld elf driver main function

Fri Nov 13 09:16:28 PST 2020

MaskRay added subscribers: aganea, sbc100, grimar, rnk.
MaskRay added a comment.

I am always trapped on this. In gdb both `b main` and `b ::main` set a breakpoint on `lld::elf::LinkerDriver::main`. For consistency, I would suggest `lld::*::LinkerDriver::link` which is used by COFF and wasm ports. However, that has the name collision problems with the free functions `lld::*::link`... (This may be less of a problem because developers don't often set breakpoints on `link`? :) )

Another choice is to rename the free functions `lld::*::link` to `linkerMain`.

@aganea @grimar @rnk @sbc100

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91418/new/

https://reviews.llvm.org/D91418