[PATCH] D89736: [ms] [llvm-ml] Implement the expression expansion operator

[Nico Weber via Phabricator via llvm-commits]

thakis requested changes to this revision.
thakis added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3200
 
-      dbgs() << "Set '" << Var.Name << "' to: '" << Var.TextValue << "'\n";
       return false;
----------------
Was the patch that added this already landed? If not, maybe remove it there instead of here :)


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6035
+            "expected text item parameter for 'elseifidn' directive");
+      else
+        return TokError(
----------------
thakis wrote:
> llvm code style says no else after return; lhs code was better
(this is still not addressed)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89736/new/

https://reviews.llvm.org/D89736