[PATCH] D91432: Move GlobalTLSAddress handling to WebAssemblyISelLowering. NFC
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 13 08:39:21 PST 2020
sbc100 added a subscriber: tlively.
sbc100 added a comment.
@tlively IIUC this is preferable?
Some of the APIs used at this level are slightly different but I'm pretty sure this is NFC.
Side note: When looking at this code compared to the PIC symbol references in the code below its interesting to me that we directly generate the `global.get` for the base address rather than relying on the pattern. i.e. we use `DAG.getMachineNode(GlobalGet..` rather than `SDValue BaseAddr = DAG.getNode(WebAssemblyISD::Wrapper`. Is this bad or something we want to avoid?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91432/new/
https://reviews.llvm.org/D91432
More information about the llvm-commits
mailing list