[PATCH] D89734: [ms] [llvm-ml] Support macro function invocations in expressions

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 08:37:56 PST 2020


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Can we also add a test where `EndStatementAtEOFStack` isn't empty at end-of-file?



================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3109
+
+  // Exit values may require lexing, unfortunately. We construct a new buffer to
+  // hold the exit value.
----------------
I think the "require lexing" part is already covered by the test you're adding. Is that right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89734/new/

https://reviews.llvm.org/D89734



More information about the llvm-commits mailing list