[PATCH] D86461: [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff.

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:402
+
+  TBVectorExt(const StringRef &TBvectorStrRef);
+
----------------
It doesn't really make sense to pass it as `const &`.
Please see https://llvm.org/docs/ProgrammersManual.html#the-stringref-class for the last sentence. 


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:929-930
+    default:
+      assert(true &&
+             "Should not come here in function parseParmsTypeWithVecInfo!");
+    }
----------------
jasonliu wrote:
> 
This comment is not addressed yet. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86461/new/

https://reviews.llvm.org/D86461