[PATCH] D91414: [RISCV] Use a macro to simplify getTargetNodeName
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 13 06:19:41 PST 2020
asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
I think moving `NODE_NAME_CASE(foo)` to the left so it's aligned where the `case` statement would be (same as the equivalent in X86ISelLowering and AMDGPUISelLowering) would be slightly better. I wouldn't be opposed to using `// clang-format off` to stop clang-format from reformatting (though it seems more common in LLVM right now to just ignore clang-format's preference).
But basically this looks good to me, and I leave it to your judgement if you want to further mess with the whitespace as suggested above. Thanks Fraser!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91414/new/
https://reviews.llvm.org/D91414
More information about the llvm-commits
mailing list