[PATCH] D88380: [VPlan] Extend VPValue to also model sub- & 'virtual' values.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 05:33:10 PST 2020


Ayal added a comment.

In D88380#2393587 <https://reviews.llvm.org/D88380#2393587>, @dmgreen wrote:

> OK sounds great. I did not know that MLIR could represent multiple values, that's good to see.
>
> I still like honestly like a more "llvm" Value/User model more, but perhaps as I read the patches I will learn to like Defs too.

Related references: https://mlir.llvm.org/docs/LangRef/#operations and the last "Traversing the def-use chains" section at the bottom of https://mlir.llvm.org/docs/Tutorials/UnderstandingTheIRStructure/ - hopefully this looks intuitive enough.

Perhaps VPDef should be renamed VPResults to clarify this correspondence, although other entities also have distinct names: VPUser/Operands and VPRecipeBase/Operation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88380/new/

https://reviews.llvm.org/D88380



More information about the llvm-commits mailing list