[llvm] dee452d - [UpdateTestChecks] Fix $ in function test for ARM.

Yvan Roux via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 03:27:16 PST 2020


Author: Yvan Roux
Date: 2020-11-13T12:26:56+01:00
New Revision: dee452da7a44e1247ff3bf300aca35dd7acaeff5

URL: https://github.com/llvm/llvm-project/commit/dee452da7a44e1247ff3bf300aca35dd7acaeff5
DIFF: https://github.com/llvm/llvm-project/commit/dee452da7a44e1247ff3bf300aca35dd7acaeff5.diff

LOG: [UpdateTestChecks] Fix $ in function test for ARM.

Removes AArch64 target checking inside 32bit ARM test to bring back
buildbots to a green state.  But $ are not well handled for ARM and it
still need to be fixed.

Added: 
    

Modified: 
    llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll
    llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll.expected

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll b/llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll
index 6c0f9e971035..a00376d3b2c9 100644
--- a/llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll
+++ b/llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll
@@ -1,6 +1,7 @@
 ; Check that we accept functions with '$' in the name.
+; TODO: This is not handled correcly on 32bit ARM and needs to be fixed.
 ;
-; RUN: llc -mtriple=arm64-unknown-linux < %s | FileCheck --prefi=LINUX %s
+; RUN: llc -mtriple=armv7-unknown-linux < %s | FileCheck --prefix=LINUX %s
 ; RUN: llc -mtriple=armv7-apple-darwin < %s | FileCheck --prefix=DARWIN %s
 ; RUN: llc -mtriple=armv7-apple-ios < %s | FileCheck --prefix=IOS %s
 ;

diff  --git a/llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll.expected b/llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll.expected
index e191b0497f0a..a6d4da41dfc1 100644
--- a/llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll.expected
+++ b/llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll.expected
@@ -1,15 +1,12 @@
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; Check that we accept functions with '$' in the name.
+; TODO: This is not handled correcly on 32bit ARM and needs to be fixed.
 ;
-; RUN: llc -mtriple=arm64-unknown-linux < %s | FileCheck --prefi=LINUX %s
+; RUN: llc -mtriple=armv7-unknown-linux < %s | FileCheck --prefix=LINUX %s
 ; RUN: llc -mtriple=armv7-apple-darwin < %s | FileCheck --prefix=DARWIN %s
 ; RUN: llc -mtriple=armv7-apple-ios < %s | FileCheck --prefix=IOS %s
 ;
 define hidden i32 @"_Z54bar$ompvariant$bar"() {
-; CHECK-LABEL: _Z54bar$ompvariant$bar:
-; CHECK:       // %bb.0: // %entry
-; CHECK-NEXT:    mov w0, #2
-; CHECK-NEXT:    ret
 entry:
   ret i32 2
 }


        


More information about the llvm-commits mailing list