[PATCH] D90304: [GlobalISel] Introduce global variant of regbankselect

[Gabriel Hjort Åkerlund via Phabricator via llvm-commits]

ehjogab added a comment.

In D90304#2391033 <https://reviews.llvm.org/D90304#2391033>, @tschuett wrote:

> Sorry for being terse. What I meant to say, you could take an existing test case and show the effects of the different algorithms. There is probably an existing test case for the existing algorithms.

Indeed, there exists ample test cases for regbank-select (at least in some targets). However, so far the ones I have seen have been quite small and therefore would probably not benefit from running the global variant. It would be good to have a test case where it is known that the greedy algorithm chooses poorly and hence the global variant should show improvement, and I recall that there was mentioning of such a case in the mailing list. In lack of such input, I will look into the existing test cases and see what I can come up with.

This does of course not exclude the need for tests showing that the global variant produces the same results as the other algorithms when there's no better solution to be had.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90304/new/

https://reviews.llvm.org/D90304