[PATCH] D91404: RFC: [ELF] Add --dwarf32-before-dwarf64 to place DWARF32 input sections before DWARF64

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lld/ELF/Options.td:150-151
+defm dwarf32_before_dwarf64: BB<"dwarf32-before-dwarf64",
+    "DWARF32 sections before DWARF64 sections",
+    "Do not place DWARF32 sections before DWARF64 sections (default)">;
+
----------------
"place" sounds like the linker isn't allowed to place DWARF32 sections first, but this obviously isn't the behaviour, if users just so happen to place objects in the right order on the command-line. Perhaps "sort" makes it clearer?


================
Comment at: lld/test/ELF/dwarf32-before-dwarf64.s:1
+# REQUIRES: ppc
+## Test --dwarf32-before-dwarf64 can order DWARF32 input sections before DWARF64
----------------
Is there a particular reason this is using ppc rather than the more common X86?


================
Comment at: lld/test/ELF/dwarf32-before-dwarf64.s:24
+# LE:      Contents of section .debug_info:
+# LE-NEXT:  0000 01000000 00000000 00000000 58010110
+# LE-NEXT:  0010 00000000 02000000 00000000 00000000
----------------
Here and below, maybe worth replacing the area patched by relocations with {{.*}} to make the test more robust?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91404/new/

https://reviews.llvm.org/D91404