[PATCH] D91276: [WebAssembly] Add new relocation types for TLS data symbols

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 23:46:39 PST 2020


tlively accepted this revision.
tlively added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.cpp:246
+ArrayRef<std::pair<unsigned, const char *>>
+WebAssemblyInstrInfo::getSerializableBitmaskMachineOperandTargetFlags() const {
+  static const std::pair<unsigned, const char *> TargetFlags[] = {
----------------
sbc100 wrote:
> tlively wrote:
> > What is this function used for?
> Good question :)  Maybe I should revert this part.. I noticed that other platforms implement this but we were missing it.  I'm guessing its for debugging of MIR or some thing like that? 
Yeah, I think that would be best until figure out what this is for and how we can test it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91276/new/

https://reviews.llvm.org/D91276



More information about the llvm-commits mailing list