[PATCH] D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes

Ta-Wei Tu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 22:15:05 PST 2020


TaWeiTu added a comment.

In D91153#2385479 <https://reviews.llvm.org/D91153#2385479>, @dstenb wrote:

> I'm not very familiar with the IndVars pass, so I have not idea if this is the correct way to solve this.

This seems correct to me, but I'm not familiar with IndVar either, so maybe someone else should take a look.
However, I think it would be better if we can return `false` in this case (i.e. if all PHI nodes created in `rewriteLoopExitValues` are dead). 
But I don't know whether there's some edge case that forces us to return `true` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91153/new/

https://reviews.llvm.org/D91153



More information about the llvm-commits mailing list