[PATCH] D91338: [X86] Zero-extend pointers to i64 for x86_64

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 22:08:47 PST 2020


pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/x32-function_pointer-2.ll:17
 ; CHECK: mov{{l|q}}	%{{e|r}}si, %{{e|r}}[[REG:.*]]{{d?}}
-; CHECK: callq	*%r[[REG]]
+; CHECK: callq	*%r
   tail call void %foo(i8* %h) nounwind
----------------
This file should not be affected, right?


================
Comment at: llvm/test/CodeGen/X86/x86-64-sret-return.ll:13
 ; X32ABI-LABEL: bar:
-; X32ABI: movl %edi, %eax
+; X32ABI: mov{{l|q}} %{{r|e}}di, %{{r|e}}ax
 
----------------
I saw other tests all use 64-bit instructions. In which case we may use 32-bit instruction?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91338/new/

https://reviews.llvm.org/D91338



More information about the llvm-commits mailing list