[PATCH] D91391: [PowerPC] Fix for excessive ACC copies due to PHI nodes

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:289
+      MachineInstr *Instr = MRI->getVRegDef(RegOp);
+      // While collecting the PHI nodes, we check they can be converted (i.e.
+      // all the operands are either copies, implicit defs or PHI nodes).
----------------
Do you mean `we check if they can be converted`?


================
Comment at: llvm/test/CodeGen/PowerPC/peephole-phi-acc.mir:188
+
+  !0 = !{i32 1, !"wchar_size", i32 4}
+  !1 = !{!"XL C/C++ for Linux on Power, (IBM Internal Development Branch), clang version 12.0.0 (git at github.ibm.com:compiler/llvm-project.git 7475f0c6d16b25fa8bd04b9fe3c5c5d9b3296f18)"}
----------------
Are these necessary to have here/can they be omitted? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91391/new/

https://reviews.llvm.org/D91391