[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.
Michael Liao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 12 12:15:07 PST 2020
hliao added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:227
+ Optional<unsigned> getAssumedAddrSpace(const Value *V) const {
+ return getTLI()->getTargetMachine().getAssumedAddrSpace(V);
----------------
arsenm wrote:
> We already have a -1 as an invalid addrspace, so optional isn't necessary
OK. Do we need to document that in the IR langref? That invalid address space ID is not documented anywhere.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91121/new/
https://reviews.llvm.org/D91121
More information about the llvm-commits
mailing list