[PATCH] D91034: [Frontend] Treat CUDA header files as CUDA source files

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 11:37:44 PST 2020


tra added a comment.

In D91034#2392057 <https://reviews.llvm.org/D91034#2392057>, @MaskRay wrote:

> @tra I have checked that clang-format does not call this  function. Do you think this is still needed?

I think the idea was to make sure that clang-format is in sync what clang regarding extension->language mapping. D90780 <https://reviews.llvm.org/D90780> adds "cuh" as a CUDA extension and this patch, IIUIC, intended to add similar treatment to clang.
So, you are correct that technically this patch is not necessary for clang-format.
Keeping them in sync does have a minor benefit of not raising a question why the two maps are different.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91034/new/

https://reviews.llvm.org/D91034



More information about the llvm-commits mailing list