[llvm] 4cdf1d2 - [MSP430] Remove unused MVT::Glue output from MSP430ISD::SELECT_CC nodes.
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 12 10:34:19 PST 2020
Author: Craig Topper
Date: 2020-11-12T10:34:01-08:00
New Revision: 4cdf1d2110238490ab02178eaa76f0cf0d29b388
URL: https://github.com/llvm/llvm-project/commit/4cdf1d2110238490ab02178eaa76f0cf0d29b388
DIFF: https://github.com/llvm/llvm-project/commit/4cdf1d2110238490ab02178eaa76f0cf0d29b388.diff
LOG: [MSP430] Remove unused MVT::Glue output from MSP430ISD::SELECT_CC nodes.
Follow up from a similar patch on RISCV 637f19c36b323cc3ab597f6ef138db53be395949
Nothing reads this Glue value that I could see. The SDNode def in
the td file does not have the SDNPOutGlue flag so I don't think
this glue would get properly propagated to MachineSDNodes if it
was used.
Added:
Modified:
llvm/lib/Target/MSP430/MSP430ISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/MSP430/MSP430ISelLowering.cpp b/llvm/lib/Target/MSP430/MSP430ISelLowering.cpp
index dcf10adb6cf0..9c6d44bf92de 100644
--- a/llvm/lib/Target/MSP430/MSP430ISelLowering.cpp
+++ b/llvm/lib/Target/MSP430/MSP430ISelLowering.cpp
@@ -1208,9 +1208,8 @@ SDValue MSP430TargetLowering::LowerSETCC(SDValue Op, SelectionDAG &DAG) const {
return SR;
} else {
SDValue Zero = DAG.getConstant(0, dl, VT);
- SDVTList VTs = DAG.getVTList(Op.getValueType(), MVT::Glue);
SDValue Ops[] = {One, Zero, TargetCC, Flag};
- return DAG.getNode(MSP430ISD::SELECT_CC, dl, VTs, Ops);
+ return DAG.getNode(MSP430ISD::SELECT_CC, dl, Op.getValueType(), Ops);
}
}
@@ -1226,10 +1225,9 @@ SDValue MSP430TargetLowering::LowerSELECT_CC(SDValue Op,
SDValue TargetCC;
SDValue Flag = EmitCMP(LHS, RHS, TargetCC, CC, dl, DAG);
- SDVTList VTs = DAG.getVTList(Op.getValueType(), MVT::Glue);
SDValue Ops[] = {TrueV, FalseV, TargetCC, Flag};
- return DAG.getNode(MSP430ISD::SELECT_CC, dl, VTs, Ops);
+ return DAG.getNode(MSP430ISD::SELECT_CC, dl, Op.getValueType(), Ops);
}
SDValue MSP430TargetLowering::LowerSIGN_EXTEND(SDValue Op,
More information about the llvm-commits
mailing list