[PATCH] D86461: [AIX][XCOFF][Patch2] decode vector information and extent long table of the traceback table of the xcoff.
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 12 09:03:51 PST 2020
DiggerLin marked 7 inline comments as done.
DiggerLin added inline comments.
================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:1036
+ if (Cur && hasExtensionTable())
+ ExtLongTBTable = DE.getU8(Cur);
----------------
jasonliu wrote:
> Since we already have the query `hasExtensionTable()`, it would make sense to call this field `ExtensionTableFlags`, and its getter `getExtensionTableFlags`.
we already has
if (Cur && hasTraceBackTableOffset())
TraceBackTableOffset = DE.getU32(Cur);
if (Cur && hasExtensionTable())
ExtensionTable = DE.getU8(Cur);
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86461/new/
https://reviews.llvm.org/D86461
More information about the llvm-commits
mailing list