[PATCH] D91362: [SelectionDAG] Add llvm.vector.{extract,insert} intrinsics

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

Presumably you're planning to add some tests?



================
Comment at: llvm/docs/LangRef.rst:16034
+The ``vec`` is the vector from which we will extract a subvector.
+The ``idx`` specifies the start index within ``vec`` of our subvector.
+
----------------
The meaning of `idx` is more nuanced that this as shown by the description attached to the ISD node it is equivalent to.  I think this is worth calling out in the langref.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1631
+                                              [llvm_anyvector_ty, LLVMMatchType<0>, llvm_i64_ty],
+                                              [IntrNoMem]>;
+
----------------
For both intrinsics you'll need to add ImmArg properties for the index parameter.  This is a requirement of the ISD node plus we don't want to open up the possibility of variable insertions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91362/new/

https://reviews.llvm.org/D91362