[PATCH] D91355: [ARM] Cortex-M7 schedule

Thu Nov 12 08:28:30 PST 2020

SjoerdMeijer added a comment.

I know this has been tuned, and the structure looks good (I'm not checking any numbers here), so looks like a good addition to me! I will let Dave, who has looked more into it, LGTM this.

================
Comment at: llvm/lib/Target/ARM/ARMScheduleM7.td:196
+//
+// Mark whether the loads/stores must be single-issue
+// Address operands are needed earlier
----------------
nit: some punctuation is missing in these comments, also in some other comments below.

================
Comment at: llvm/test/tools/llvm-mca/ARM/m7-int.s:1297
+# CHECK-NEXT: 0.50   0.50    -      -      -      -     1.00    -      -      -      -      -      -     uxth.w	r0, r1, ror #8
+# CHECK-NEXT:  -      -      -      -      -      -      -      -      -      -      -      -      -     wfe
+# CHECK-NEXT:  -      -      -      -      -      -      -      -      -      -      -      -      -     wfi
----------------
nit: we probably don't need these here I guess.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91355/new/

https://reviews.llvm.org/D91355