[PATCH] D91356: AMDGPU: Factor out large flat offset splitting

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1736
+
 template <bool IsSigned>
 bool AMDGPUDAGToDAGISel::SelectFlatOffset(SDNode *N,
----------------
Not really related to your change, but it has always seemed crazy to me to have IsSigned as a template argument instead of a normal argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91356/new/

https://reviews.llvm.org/D91356