[PATCH] D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause

Thu Nov 12 06:50:01 PST 2020

yhegde added a comment.

In D90697#2372471 <https://reviews.llvm.org/D90697#2372471>, @kiranchandramohan wrote:

> Thanks for this patch.
>
> Can you check what is happening with this test?
>
>         subroutine sb(q,nx)
>         integer :: q(100)
>         integer :: t1, t8
>   !$OMP PARALLEL DO PRIVATE(k,t1) REDUCTION(max:t8)
>         do k=1,nx
>           t1=q(k)
>           t8=max(t8,t1)
>         enddo
>         end

Thank you very much @kiranchandramohan and @clementval for all the review comments. Working on this test case. Looks like there is nothing defined for max, min etc like parser::DefinedOperator::IntrinsicOperator is defined for Add, Subtract etc. I have attempted to define them. Will send the patch soon. Please let me know if the changes are in rt direction.  Thanks again. 
regards

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90697/new/

https://reviews.llvm.org/D90697