[PATCH] D91093: [X86 and PPC] Tune SelectionDAG CTPOP emulation via TLI hook

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:5335
+unsigned X86TargetLowering::getCustomCtpopCost(EVT VT, ISD::CondCode Cond) const {
+  assert(VT.isVector());
+
----------------
How are we able to make that assertion? I don't see anything in the caller that filters out scalar types. We probably need at least 1 scalar test as a sanity check if the plan is that this optimization is vector-only for x86.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91093/new/

https://reviews.llvm.org/D91093