[PATCH] D91249: [obj2yaml] - Sort sections by file offsets when dumping them.

Thu Nov 12 02:50:22 PST 2020

grimar planned changes to this revision.
grimar added a comment.

In D91249#2390861 <https://reviews.llvm.org/D91249#2390861>, @jhenderson wrote:

> I'm a little confused here. If we have an ELF with sections .foo, .bar and .zed in that order in the section header table, but with offsets 0x300, 0x200, and 0x100 respectively, I'd expect the obj2yaml output to mantain at least the offset property (the section header table order is arguably less important, although if that order can be maintained too, great). This change appears to be changing the offsets of the sections.

Actually I am confused too. It definetely was not my intention to change the offsets and I had such bug when developed this patch and was sure that fixed it.
Something is wrong here. I'll recheck after finish with D91152 <https://reviews.llvm.org/D91152>.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91249/new/

https://reviews.llvm.org/D91249