[PATCH] D84118: [Debuginfo][Salvaging] (5/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 02:43:26 PST 2020


djtodoro added inline comments.


================
Comment at: llvm/lib/IR/Instruction.cpp:822
+
+  if (getModule()->getDwarfVersion() >= 5) {
+    if (isa<AllocaInst>(*this)) {
----------------
djtodoro wrote:
> djtodoro wrote:
> > why only for DWARF 5?
> > There is dw_op_gnu_implicit_pointer for the later version ?
> Please add a comment describing what we are doing here.
'later version' --> I meant earlier 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84118/new/

https://reviews.llvm.org/D84118



More information about the llvm-commits mailing list