[PATCH] D90304: [GlobalISel] Introduce global variant of regbankselect

Gabriel Hjort Ã…kerlund via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 02:36:13 PST 2020


ehjogab added a comment.

In D90304#2385167 <https://reviews.llvm.org/D90304#2385167>, @gargaroff wrote:

> I haven't had the time to test this in the new state yet, but I would love to see this integrated. However I'm not in a position to review and approve this. Someone of the GlobalISel folks should do that. As for testing, ideally you could simply leverage the existing tests of the existing GlobalISel backends by enabling this algorithm conditionally. This also requires the approval of those backend maintainers however.
>
> Maybe it would make sense to ping the mailing list again, explaining the current state, giving some numbers how this algorithm impacts compile time and code gen, and try to discuss some integration strategy.

Thanks for your suggestions! I'll attend to them when my work pipeline has cleared up a bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90304/new/

https://reviews.llvm.org/D90304



More information about the llvm-commits mailing list