[PATCH] D91273: [ARM] Revert low overhead loops with calls before registry allocation.

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVETPAndVPTOptimisationsPass.cpp:162
+bool MVETPAndVPTOptimisations::RevertLoopWithCall(MachineLoop *ML) {
+  LLVM_DEBUG(dbgs() << "MergeLoopEnd on loop " << ML->getHeader()->getName()
+                    << "\n");
----------------
SjoerdMeijer wrote:
> MergeLoopEnd?
Ah, yeah. This gets renames to that in a later patch. This function is essentially the "Merge LoopDec and LoopEnd" function, that needs to do these things too. I was trying to get things out of the way before that.


================
Comment at: llvm/lib/Target/ARM/MVETPAndVPTOptimisationsPass.cpp:701
+    Modified |= RevertLoopWithCall(ML);
     Modified |= ConvertTailPredLoop(ML, DT);
+  }
----------------
SjoerdMeijer wrote:
> Do we need to run ConvertTailPredLoop if we have reverted above?
Yeah, that should already be handled by it not finding loop components. The RevertLoopWithCall will become MergeLoopEnd in later patches, the return value of which is "has the code been modified", not "has the loop been reverted".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91273/new/

https://reviews.llvm.org/D91273