[PATCH] D61767: [llvm-elfabi] Emit ELF header and string table section

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 01:53:23 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-elfabi/fail-file-write.test:16
+
+# ERR: Permission denied when trying to open
----------------
jhenderson wrote:
> Please check the full error here, rather than a partial one. Additionally, I would be suspicious that the error message will be different depending on whether the host OS is Linux or Windows. Please could you check? If you don't have access to both systems, let me know, and I can test the one you can't.
Looking at the pre-merge checks this test is failing on Windows as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61767/new/

https://reviews.llvm.org/D61767



More information about the llvm-commits mailing list