[PATCH] D91294: [X86] When storing v1i1/v2i1/v4i1 to memory, make sure we store zeros in the rest of the byte

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 01:35:01 PST 2020


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - there's a number of optimisations in the new kshift mask clearing codegen that we're missing but we can fix those up later.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:23882
                             DAG.getUNDEF(MVT::v16i1), StoredVal,
                             DAG.getIntPtrConstant(0, dl));
     StoredVal = DAG.getBitcast(MVT::i16, StoredVal);
----------------
Any idea why we pad with a INSERT_SUBVECTOR here but use a CONCAT_VECTORS in the other case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91294/new/

https://reviews.llvm.org/D91294



More information about the llvm-commits mailing list