[PATCH] D91275: [FileCheck] Disallow unused prefixes in llvm/test/Analysis

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks okay, but I'm not really up to speed on the implications of lit substitutions, so it would be better for someone else to review if possible. In the ideal world, we'll revert this and any similar patches and just use the option explicitly, once we've fixed all the tests and changed the default to reduce obfuscation, in my opinion, but I'm not sure it's a big issue.



================
Comment at: llvm/test/Analysis/lit.local.cfg:5
+fc = ToolSubst('FileCheck', unresolved='fatal')
+# insert this first. Then, we'll first update the blank FileCheck command; then,
+# the default substitution of FileCheck will replace it to its full path.
----------------



================
Comment at: llvm/test/Analysis/lit.local.cfg:9
+    'FileCheck --allow-unused-prefixes=false'))
\ No newline at end of file

----------------
Nit: need new line at EOF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91275/new/

https://reviews.llvm.org/D91275