[PATCH] D90829: [GlobalISel][TableGen] fix seg fault for zero instruction

[Gabriel Hjort Åkerlund via Phabricator via llvm-commits]

ehjogab added inline comments.


================
Comment at: llvm/test/TableGen/GlobalISelEmitter-zero-instr.td:6
+
+// CHECK: return MatchTable
+def : Pat<(zext (i16 (trunc i32:$src))),
----------------
ehjogab wrote:
> bjope wrote:
> > Nice that we no longer crash, but I don't know how relevant this check is. What about checking that we get the "warning: Skipped pattern: Dst pattern root isn't a known leaf" message instead?
> That'd be nice, but can it be done? I'm not very familiar with FileCheck... 
I missed to mention that this check at least checks that we no longer crashes, so it's not entirely useless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90829/new/

https://reviews.llvm.org/D90829