[PATCH] D91314: [RISCV] ELF attribute for Zfh extension.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2144
+        setFeatureBits(RISCV::FeatureExtZfh, "experimental-zfh");
+        drop_char_num = 3;
       } else
----------------
Having each X and Z extension hard-code its length is going to get ugly (and this doesn't match the code style for variable names). Instead I think we should be making good use of StringRef::consume_front.


================
Comment at: llvm/test/MC/RISCV/attribute-with-insts.s:13
 
-.attribute arch, "rv64i2p0_m2p0_a2p0_d2p0_c2p0"
+.attribute arch, "rv64i2p0_m2p0_a2p0_d2p0_c2p0_zfh0p1"
 
----------------
This changes the test; we're no longer checking whether D implies F but instead whether (D or Zfh) implies F.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91314/new/

https://reviews.llvm.org/D91314