[PATCH] D90884: [SmallVector] Add a default small size.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 18:06:30 PST 2020


mehdi_amini added a comment.

`DefaultSmallVector` is quite a "mouthful" though, I'd have thought we'd look for a "default container" that is easy to type if we have it everywhere.

Why are you against `llvm::Vector` with `short string optimization`? I know that `std::vector` does not have any inline storage, but that seems like a weak reason to me: from any behavior point of view it exposes the same interface
 I see it similarly to how some implementation of `std::string` have a small-string optimization and others don't: it is an implementation detail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90884/new/

https://reviews.llvm.org/D90884



More information about the llvm-commits mailing list