[PATCH] D91043: [DebugInfo] Fix convert-loclist.ll

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D91043#2390184 <https://reviews.llvm.org/D91043#2390184>, @rnk wrote:

> This test seems fairly specific, and a bit fragile. I don't think we will get much benefit from trying to generalize it to non-x86 targets.

Sure enough - didn't mean to suggest that we should generalize it.

> If a triple must be passed, there's no reason to use `%llc_dwarf`, `llc` is fine.

My understanding is that more than that, as @luismarques said, a specific triple + llc_dwarf shouldn't be used together, if I recall correctly. They fail when used together, because llc doesn't accept two triples (doesn't have any support for "pick the last", for instance), maybe/I think/going on past experience/vague recollection?

The fix seems fine to me - but I think there's something that at least I'm not understanding and would like to understand, since it's related to understanding the correctness of this fix: Why are there a bunch of other uses of %llc_dwarf in the DebugInfo/X86 tests - why don't they have the same problem as this test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91043/new/

https://reviews.llvm.org/D91043