[PATCH] D90868: [IR] Define @llvm.ptrauth intrinsics.

Daniel Kiss via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 16:49:03 PST 2020


danielkiss added inline comments.


================
Comment at: llvm/docs/PointerAuth.md:83
+```llvm
+declare i64 @llvm.ptrauth.sign(i64 <value>, i32 <key>, i64 <extra data>)
+```
----------------
I'd call this parameter `discriminator`, for me it would more intuitive than "extra data". 
e.g. llvm.ptrauth.blend takes two `discriminators` and returns a new one that should go here.

also later we say:
```
// Sign an unauthenticated pointer using the specified key and discriminator,
// passed in that order.
```
Architecture call's it `modifier` because it kind a modifies the key.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90868/new/

https://reviews.llvm.org/D90868



More information about the llvm-commits mailing list