[PATCH] D91043: [DebugInfo] Fix convert-loclist.ll

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

In D91043#2389617 <https://reviews.llvm.org/D91043#2389617>, @dblaikie wrote:

> I'm a bit confused - looks like there's a bunch of other uses of %llc_dwarf in this test directory - any idea why those ones don't fail in the same way/for you?

The problem isn't the `%llc_dwarf`, it's the use of an x86-specific test without an x86 target triple.

The only reason I changed the `%llc_dwarf` to `llc` is because I thought that `%llc_dwarf` shouldn't be used in combination with an explicit target triple command line option. I thought that was the case due to seeing, for instance, commits like [1]. That made some sense to me: the `%llc_dwarf` would allow you to tweak the triple to ensure proper ELF/DWARF support on certain platforms, so if you explicitly specified the triple then they could clash. Yet, I see one test in that directory that specifies a triple in the RUN line (`dwarf-callsite-related-attrs.ll`, but maybe that one just needs to be fixed). Most of the tests also specify a triple in the IR, so I guess at least that way it's OK.

So I'm not sure what's the best way to fix this, but the important point is that the backend needs to be told to generate x86 code, otherwise it will trip on the x86-specific attributes and so on.

[1] http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20160815/382269.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91043/new/

https://reviews.llvm.org/D91043