[PATCH] D89285: [lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB

[Greg Clayton via Phabricator via llvm-commits]

clayborg accepted this revision.
clayborg added a comment.

LGTM as long as local symbols always have names (see inlined comment).



================
Comment at: lld/MachO/SyntheticSections.cpp:643
+          if (!defined->isExternal()) {
+            uint32_t strx = stringTableSection.addString(sym->getName());
+            localSymbols.push_back({sym, strx});
----------------
Do all symbols have names? If not we should check that the symbol has a name and not add it if it doesn't?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89285/new/

https://reviews.llvm.org/D89285