[PATCH] D91221: [MachO] Allow the LC_IDENT load command

[Jason Molenda via Phabricator via llvm-commits]

jasonmolenda added a comment.

I discussed this with KevinE in the past and he was adamant that he didn't want LC_IDENT being used for this.  I don't have strong feelings.  I think it was an old load command used for something else altogether decades ago and it started getting used in kernel corefiles and he wasn't thrilled with that. There is a Mach-O LC_NOTE load command that allows for the kernel version string to be stored in the kernel file ("kern ver str") but it hasn't been adopted by darwin kernel dumpers yet.

to be clear: I don't object to ignoring this in the llvm tools, but it was an intentional decision in the past. I don't think that should weigh especially heavily on us today though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91221/new/

https://reviews.llvm.org/D91221