[PATCH] D91289: [AMDGPU] Define and use names for export targets. NFC.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 12:42:23 PST 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.h:284
+// Export targets as defined by the encoding of the EXP instruction.
+enum ExportTarget {
+  ET_MRT0 = 0,
----------------
It is better to live in the SIDefines.h. That encoding fields all live there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91289/new/

https://reviews.llvm.org/D91289



More information about the llvm-commits mailing list