[PATCH] D91034: [Frontend] Treat CUDA header files as CUDA source files

Artem Belevich via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 11:00:08 PST 2020


On Wed, Nov 11, 2020 at 10:35 AM Anatoliy Tomilov via Phabricator <
reviews at reviews.llvm.org> wrote:

> tomilov added a reviewer: tra.
> tomilov added a subscriber: tra.
> tomilov added a comment.
>
> > For some reason I'm not allowed to post on the review.
>
> I hope it is resolved now.
>

Nope. "You do not have permission to edit this object."


>
> > I'd add .cu.h and .cu.cc to the list.
>
Hmm, I wonder how that would interact with plain ".cc" and ".h". It
probably needs to move up the comparison chain.


>
> @tra  Never heard about and never seen such a file extensions. Can you
> link statistically significant amount of .cu.h or .cu.cc sources?
>

Tensorflow qualifies, I think:

https://github.com/tensorflow/tensorflow/tree/master/tensorflow/core/kernels

In general, CUDA compilation with bazel is done as a C++ compilation with
few extra flags and it will not accept .cu or .cuh.

--Artem


>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D91034/new/
>
> https://reviews.llvm.org/D91034
>
>

-- 
--Artem Belevich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201111/0c95e7e8/attachment.html>


More information about the llvm-commits mailing list