[PATCH] D91275: [FileCheck] Disallow unused prefixes in llvm/test/Analysis

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 10:25:29 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/lit.cfg.py:87
+# expanding FileCheck to the full path.
+config.substitutions.append(('%FileCheckWithUnusedPrefixes%', 
+    'FileCheck --allow-unused-prefixes=true'))
----------------
Does `('FileCheck', 'FileCheck --allow-unused-prefixes=true')` work?

You may take a look at some tools like opt,llc,llvm-mc,etc. They expand to the absolute paths. It is possible that FileCheck can use the same trick, but expand with another argument, so that you don't have to update the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91275/new/

https://reviews.llvm.org/D91275



More information about the llvm-commits mailing list