[PATCH] D90848: llvmbuildectomy - part 2

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:620
+  else()
+    # We can use PRIVATE since SO knows its dependent libs.
+    set(libtype PRIVATE)
----------------
Meinersbur wrote:
> SO = significant other?
The comment is not mine, I'd guess *Shared Objects*


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:643-645
+    set_property(TARGET ${name} PROPERTY LLVM_LINK_COMPONENTS ${ARG_LINK_COMPONENTS} ${LLVM_LINK_COMPONENTS})
+    set_property(TARGET ${name} PROPERTY LLVM_LINK_LIBS ${ARG_LINK_LIBS})
+    set_property(TARGET ${name} PROPERTY LLVM_LIBTYPE ${libtype})
----------------
Meinersbur wrote:
> Is there somewhere an overview/description of these target properties?
I've added a description of the public properties in `add_llvm_component_library` and commented on private properties inplace.


================
Comment at: llvm/lib/ExecutionEngine/MCJIT/CMakeLists.txt:7
+
+  LINK_COMPONENTS Core ExecutionEngine Object RuntimeDyld Support Target
   )
----------------
Meinersbur wrote:
> Could you put the dependees on separate line, like `DEPENDS` options above?
Done for all the files


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90848/new/

https://reviews.llvm.org/D90848