[PATCH] D91218: Prevent FENTRY_CALL reordering

Wed Nov 11 06:25:05 PST 2020

iii added a comment.

In D91218#2388416 <https://reviews.llvm.org/D91218#2388416>, @jonpa wrote:

> In D91218#2388401 <https://reviews.llvm.org/D91218#2388401>, @iii wrote:
>
>> - Add isCall to FENTRY_CALL in Target.td.
>
> Do you still need to create the extra basic block?

I think it's better to keep it in case isCall is changed to not be a scheduling boundary.

Btw, I used the patch a bit more, and realized I broke debuginfo generation, because I did not adjust isCandidateForCallSiteEntry.
So I added a test for this and will send an update once the regtest finishes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91218/new/

https://reviews.llvm.org/D91218